Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(node-sdk): update outdated metric documentation. #3226

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

The @opentelemetry/node-sdk package's documentation was outdated. This PR updates the metrics documentation of this package.

Related #3224

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@pichlermarc pichlermarc added Skip Changelog sdk:metrics Issues and PRs related to the Metrics SDK labels Sep 2, 2022
@pichlermarc pichlermarc requested a review from a team September 2, 2022 14:59
@pichlermarc pichlermarc added signal:metrics Issues and PRs related to general metrics signal and removed sdk:metrics Issues and PRs related to the Metrics SDK labels Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #3226 (e355599) into main (597ea98) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
+ Coverage   93.22%   93.24%   +0.01%     
==========================================
  Files         196      196              
  Lines        6541     6541              
  Branches     1373     1373              
==========================================
+ Hits         6098     6099       +1     
+ Misses        443      442       -1     
Impacted Files Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 91.13% <ø> (ø)
...-trace-base/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@legendecas legendecas linked an issue Sep 6, 2022 that may be closed by this pull request
@legendecas legendecas added this to the Metrics GA milestone Sep 7, 2022
@dyladan dyladan removed this from the Metrics GA milestone Sep 7, 2022
@dyladan dyladan merged commit 5005b0b into open-telemetry:main Sep 7, 2022
@dyladan dyladan deleted the docs/node-sdk-metrics branch September 7, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
signal:metrics Issues and PRs related to general metrics signal Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metricExporter and metricInterval are missing in the NodeSDK 0.32
3 participants